bug: Undefined behavior regression #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had allowed strings to be sent via `note-c` without a newline-terminator. Subsequently, we decided this was undefined behavior that should not be supported. This caused a regression in downstream testing, and we have restored the original behavior (although undefined by the Notecard communication specification).
rayozzie
approved these changes
Feb 22, 2024
Allocated string did NOT have a NULL-terminator required by `strstr`. Fake Function Framework (FFF) does not make copies of strings for testing mocks, so it was instead accessing released memory which was triggering valgrind errors.
zfields
force-pushed
the
zak-ub-fix
branch
3 times, most recently
from
4639a45
to
2bc8d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had allowed strings to be sent via
note-cwithout a newline-terminator.Subsequently, we decided this was undefined behavior that should not be supported.
This caused a regression in downstream testing, and we have restored the original
behavior (although undefined by the Notecard communication specification).