Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh page after setting new global address #496

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Refresh page after setting new global address #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/views/ConfigurationGeneralView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,10 @@ const addNewVehicleConnection = async (): Promise<void> => {
const setGlobalAddress = async (): Promise<void> => {
await globalAddressForm.value.validate()
mainVehicleStore.globalAddress = newGlobalAddress.value

// Temporary solution to actually set the address and connect the vehicle, since this is non-reactive today.
// TODO: Modify the store variables to be reactive.
location.reload()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a temporary solution, can we add a clear todo message saying the future indented solution ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

}

const setWebRTCSignallingURI = async (): Promise<void> => {
Expand Down