Refresh page after setting new global address #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,6 +229,7 @@ const addNewVehicleConnection = async (): Promise<void> => { | |||
| const setGlobalAddress = async (): Promise<void> => { | |||
| await globalAddressForm.value.validate() | |||
| mainVehicleStore.globalAddress = newGlobalAddress.value | |||
| location.reload() | |||
There was a problem hiding this comment.
Since this is a temporary solution, can we add a clear todo message saying the future indented solution ?
rafaellehmkuhl
force-pushed
the
temp-fix-set-global-address
branch
from
ba9162d to
81d92b5
Compare
This is a temporary fix for the problem of setting a new global address and the configuration not being done.
rafaellehmkuhl
force-pushed
the
temp-fix-set-global-address
branch
from
81d92b5 to
2664af8
Compare
patrickelectric
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for the problem of setting a new global address and the configuration not being done.