Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from yarn to bun #481

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Conversation

patrickelectric
Copy link
Member

@patrickelectric patrickelectric commented Sep 15, 2023

Improve install + build + linters speed in almost 2x.

Comment on lines -47 to -49
- os: windows-latest
suffix: windows
extension: exe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this remove intentional?

Copy link
Member Author

@patrickelectric patrickelectric Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, bun does not have support officially for windows. We can add it back with yarn build. But I just want to avoid the extra logic right now inside the yml.

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here and it's working.

Just need to rebase over master before merging.

Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
@patrickelectric patrickelectric merged commit 9130505 into bluerobotics:master Sep 15, 2023
4 checks passed
@patrickelectric patrickelectric deleted the bun branch September 15, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants