Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Windows binary is being generated #486

Closed
rafaellehmkuhl opened this issue Sep 19, 2023 · 6 comments · Fixed by #854
Closed

No Windows binary is being generated #486

rafaellehmkuhl opened this issue Sep 19, 2023 · 6 comments · Fixed by #854
Assignees
Labels
bug Something isn't working P2 - Normal Priority Task that should be done

Comments

@rafaellehmkuhl
Copy link
Member

This is due to the moving to Bun.

Patrick suggested using Yarn to build the Windows version.

@rafaellehmkuhl rafaellehmkuhl added the bug Something isn't working label Sep 19, 2023
@rafaellehmkuhl
Copy link
Member Author

@patrickelectric can you take a look at that when possible?
Brian was asking for a Windows binary, but we don't have an updated one anymore.

@rafaellehmkuhl
Copy link
Member Author

@patrickelectric since you were already working with the CI for the flatpak deployment, could you also take a look at this one?

@patrickelectric
Copy link
Member

We have both extension and the website: https://blueos.cloud/cockpit
Is there a need right now for windows artifacts ?

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Oct 19, 2023

We have both extension and the website: https://blueos.cloud/cockpit Is there a need right now for windows artifacts ?

Someone not directly using BlueOS or without an internet connection.

But more important than that is so we do not start with the wrong foot deprecating one system over another in a project that sells itself as natively cross-platform.

@Williangalvani
Copy link
Member

I also suspect that https cockpit won't be able to task to unsecure mavlink over ws, will it?

@rafaellehmkuhl
Copy link
Member Author

I also suspect that https cockpit won't be able to task to unsecure mavlink over ws, will it?

I think it is possible if the unsecure mavlink is served locally. Browsers do ignore security check on localhost paths for most things.

But independent of that, I think it is a big mistake for us to treat any of the three main desktop OSs in a different way, as we are doing with Windows right now.

We should either have binaries for all of them, or for none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 - Normal Priority Task that should be done
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants