Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mission planning UI issues #1430

Conversation

ArturoManzoli
Copy link
Contributor

  • Increased the timeout for mission upload and download on the ardupiot library. Long missions and surveys were not being transferred due to short time limit on comm requests;
  • Relocated and improved the linear progress bar that provided visual feedback for the mission transferring processes.

image

image

/>
<p v-if="fetchingMission" class="fixed top-[58px] left-[7px] flex text-md font-bold text-white z-30 drop-shadow-md">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the map widget is not full-screened, this bar gets on a weird place:

image

You can reuse the logic of the map bottom buttons so its reactive with the map position.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch
Lets make this position dynamic

@ArturoManzoli ArturoManzoli force-pushed the fix-mission-planning-UI-issues branch from 344bf78 to 605b303 Compare November 1, 2024 13:12
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not it's working as it was before, with the bar always on top:

Kapture.2024-11-04.at.21.48.33.mp4

@ArturoManzoli ArturoManzoli force-pushed the fix-mission-planning-UI-issues branch from 605b303 to b003f91 Compare November 4, 2024 18:02
@ArturoManzoli
Copy link
Contributor Author

Not it's working as it was before, with the bar always on top:

That's odd. Here is normal, since the last push.

Now, I modified the text position to correspond to the map widget's top, just to have something to push. But nothing related to the linear progress bar.

Do you mind checking again?
If again its not correct on your computer, do you have any clue why its running okay here and not on yours?

Screenshare.-.2024-11-04.2_59_58.PM.mp4

@rafaellehmkuhl
Copy link
Member

rafaellehmkuhl commented Nov 4, 2024

Not it's working as it was before, with the bar always on top:

That's odd. Here is normal, since the last push.

Now, I modified the text position to correspond to the map widget's top, just to have something to push. But nothing related to the linear progress bar.

Do you mind checking again? If again its not correct on your computer, do you have any clue why its running okay here and not on yours?

The problem is in the Map widget.
You tested the mission planning on full-screen, not the map widget 😅
The problem happens in the Map widget specifically, while on full-screen.

@ArturoManzoli ArturoManzoli force-pushed the fix-mission-planning-UI-issues branch from b003f91 to 26198d3 Compare November 4, 2024 19:15
@ArturoManzoli
Copy link
Contributor Author

ArturoManzoli commented Nov 4, 2024

The problem is in the Map widget. You tested the mission planning on full-screen, not the map widget 😅 The problem happens in the Map widget specifically, while on full-screen.

That's strange..
Here is a pic of two map widgets on flight mode, downloading a mission from the vehicle:

I have again just improved the text placement on the last push.
Check if its okay on your computer too:

image

Btw, should the vehicle path be already bright yellow on your branch?
image

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and it's working!

Maybe I checked the branch from the other PR in the last review?

@rafaellehmkuhl rafaellehmkuhl merged commit 3798327 into bluerobotics:master Nov 4, 2024
10 checks passed
@ArturoManzoli
Copy link
Contributor Author

ArturoManzoli commented Nov 4, 2024

Tested again and it's working!

Maybe I checked the branch from the other PR in the last review?

Maybe it was checked on the other branch 😃 I do that from time to time

Nice to hear that is working.

@vshie
Copy link

vshie commented Nov 25, 2024

I tested and it uploads saying success, but when going to flight view or back to plan view the waypoints of uploaded mission are not present? Maybe loading mission from what's on vehicle isn't supported yet?

@rafaellehmkuhl
Copy link
Member

rafaellehmkuhl commented Nov 25, 2024

I tested and it uploads saying success, but when going to flight view or back to plan view the waypoints of uploaded mission are not present? Maybe loading mission from what's on vehicle isn't supported yet?

Actually to download the uploaded mission you have to open the map widget and click the "download" button (arrow pointing down). I know, bad.

The whole process is being reviewed and will be improved during December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants