-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mission planning UI issues #1430
Fix mission planning UI issues #1430
Conversation
ArturoManzoli
commented
Oct 30, 2024
- Increased the timeout for mission upload and download on the ardupiot library. Long missions and surveys were not being transferred due to short time limit on comm requests;
- Relocated and improved the linear progress bar that provided visual feedback for the mission transferring processes.
src/components/widgets/Map.vue
Outdated
/> | ||
<p v-if="fetchingMission" class="fixed top-[58px] left-[7px] flex text-md font-bold text-white z-30 drop-shadow-md"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Lets make this position dynamic
344bf78
to
605b303
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not it's working as it was before, with the bar always on top:
Kapture.2024-11-04.at.21.48.33.mp4
605b303
to
b003f91
Compare
That's odd. Here is normal, since the last push. Now, I modified the text position to correspond to the map widget's top, just to have something to push. But nothing related to the linear progress bar. Do you mind checking again? Screenshare.-.2024-11-04.2_59_58.PM.mp4 |
The problem is in the Map widget. |
… progress bar Signed-off-by: Arturo Manzoli <[email protected]>
…d surveys Signed-off-by: Arturo Manzoli <[email protected]>
b003f91
to
26198d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again and it's working!
Maybe I checked the branch from the other PR in the last review?
Maybe it was checked on the other branch 😃 I do that from time to time Nice to hear that is working. |
I tested and it uploads saying success, but when going to flight view or back to plan view the waypoints of uploaded mission are not present? Maybe loading mission from what's on vehicle isn't supported yet? |
Actually to download the uploaded mission you have to open the map widget and click the "download" button (arrow pointing down). I know, bad. The whole process is being reviewed and will be improved during December. |