Implement new UI to Configurations - general #1002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not needed in the new context.
…top and bottom bars The widgets can still be maximized to full-screen as usual.
…MED_VALUE_FLOATs`
This raises an warning everytime the modal is open.
With the former implementation, Vue warns about "no value for" props that were not passed.
Just warn the user in that case.
ArturoManzoli
force-pushed
the
969-Implement-Configuration-General
branch
from
c9f0983 to
92b7860
Compare
For example, videos that were being recorded and the user refreshed Cockpit, or the computer shut down during the recording.
This makes a huge difference when downloading multiple videos.
…without compression This reduces the compression time of a 22min/1.1GB video from 36s to 11s. The final zip file size is basically the same, as the video is already compressed (WEBM).
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
…sues Signed-off-by: Arturo Manzoli <[email protected]>
* Change MainVehicleConnetion and WebRTCConnection URIs to use storage and to be reactive * Change video.ts to use new computed property
* Change the way as the URIs are configured to make sure they are reactive and stored properly on storage when using custom ones
It was mistakenly removed on a recent commit.
…rest` The `:6040` path does not work with BlueSim, for example.
rafaellehmkuhl
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Some behavior problems:
- The menu names are selectable.
- I cannot close the general menu once open.
This should also be rebased with the latest changes in master (that add Lago's reactivity changes and my RTC configuration part). This rebase can also be done when we merge the interface-rework branch into master. It's up to you to do it now or on the future.
ArturoManzoli
force-pushed
the
969-Implement-Configuration-General
branch
3 times, most recently
from
05a26d2 to
0557467
Compare
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
969-Implement-Configuration-General
branch
3 times, most recently
from
6e91d77 to
04719b4
Compare
|
@ArturoManzoli it appears that a rebase is necessary in this PR. |
ArturoManzoli
force-pushed
the
969-Implement-Configuration-General
branch
2 times, most recently
from
2e7b279 to
7c9594a
Compare
ArturoManzoli
force-pushed
the
969-Implement-Configuration-General
branch
from
7c9594a to
803bf6d
Compare
|
Just noticing that this auto-close from Github without allowing the PR to be reopen is a limitation from Github itself that happens when one push-forces to a branch linked to a closed PR. Unfortunately we didn't know about this limitation and had to reopen the PR. The new one can be found here. More about the limitation here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main features:
Regular size screens:
https://github.com/bluerobotics/cockpit/assets/14910201/c8c67845-fcf5-43a7-8d1f-d2e2477f4e4a
Very small screens:
https://github.com/bluerobotics/cockpit/assets/14910201/63df7c5b-4140-4fb6-99f5-6a55bec1110e
Closes #969