Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch with latest changes #1016

Merged

Conversation

ArturoManzoli
Copy link
Contributor

Updates prior to merging the Interface changes on PR #1002

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several conflicts that must be resolved here:

image

Apparently they are mostly changes that you added on the main-menu PR to be able to merge it in the master.

@ArturoManzoli ArturoManzoli force-pushed the interface-rework branch 5 times, most recently from ebb8473 to 026f6b6 Compare June 20, 2024 09:55
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arturo, it looks like it's still adding unknown commits to the middle of the branch.
Those highlighted commits are in the master branch, but they do not have the same hash. Maybe you're taking those commits from your local branch, instead of the upstream master?

This PR:
image

Upstream master:
image

@patrickelectric
Copy link
Member

If you are having problems with rebase, try to cherry-pick a range of commits

@ArturoManzoli ArturoManzoli force-pushed the interface-rework branch 2 times, most recently from 50b32a5 to 387b5ca Compare June 20, 2024 15:02
@ArturoManzoli ArturoManzoli deleted the branch bluerobotics:interface-rework June 20, 2024 15:04
@ArturoManzoli ArturoManzoli reopened this Jun 20, 2024
@rafaellehmkuhl rafaellehmkuhl merged commit 387b5ca into bluerobotics:interface-rework Jun 20, 2024
8 checks passed
@ArturoManzoli ArturoManzoli deleted the interface-rework branch July 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants