-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jonathan Miles -- Django I #287
Open
jonathantmiles
wants to merge
1
commit into
bloominstituteoftechnology:master
Choose a base branch
from
jonathantmiles:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,16 @@ | ||
- Summarize the key steps in the deployment process. | ||
- Summarize the key steps in the deployment process. | ||
- What went well? | ||
- What challenges did you face? | ||
- What challenges did you face? | ||
- How far did you get? | ||
- We have utilized docs from several different projects over the course of this Sprint. | ||
- Which docs did you think were the most helpful? | ||
- Name one or two specific things about this resource that you think sets it apart from other docs you have referenced in the past. | ||
- Which docs did you think were the most helpful? | ||
- Name one or two specific things about this resource that you think sets it apart from other docs you have referenced in the past. | ||
|
||
|
||
Deploying to Heroku requires a few key steps. First, one has to make an account with Heroku. This is as straightforward as signing up for any other service online. Then, from the command line, set a few key variables (these can also be reached online from the Heroku dashboard). Finally, the app has to be deployed by choosing a unique app name and pushing your repo to Heroku's git. | ||
|
||
Pushing my preexisting project was quick and easy; the steps and guidance listed on the Lambda School repository for the assignment was helpful and straightforward. I did, however, have to both actually assign the default variables in Heroku (I had applied the instructions for this part to the secret .env file instead), including a COLLECTSTATIC variable that wasn't mentioned in the instructions. I persevered by carefully reading the instructions on the command line whenever something didn't work. | ||
|
||
The result is a website that is at its bare minimum of functionality; it's even worse looking than the local deployment. I shouldn't be surprised; the assignment this week was to deploy a backend, not to make a pretty frontend. | ||
|
||
The overall set of Lambda tutorial videos was very good and helpful. It was a clear implementation of our goals and was unambiguous. (I know this is low-hanging fruit, but the other docs I basically read as far as the installation instructions, which was a couple of paragraphs, and didn't have much trouble with troubleshooting them.) That said, I did appreciate the docs for e.g. CORS and dj_database_url which had the installation information right at the top of their' repos' front page. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Jonathan, you did a great job with this project. Overall I have no complaints. You worked at a timely pace and got your MVP for this week's project and Sprint finished in a flash. I look forward to seeing what you come up with for next week's project. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job outlining your steps for your deployment process, very well explained.