Jonathan Miles -- Django I #287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| Deploying to Heroku requires a few key steps. First, one has to make an account with Heroku. This is as straightforward as signing up for any other service online. Then, from the command line, set a few key variables (these can also be reached online from the Heroku dashboard). Finally, the app has to be deployed by choosing a unique app name and pushing your repo to Heroku's git. |
There was a problem hiding this comment.
Great job outlining your steps for your deployment process, very well explained.
|
|
||
| The result is a website that is at its bare minimum of functionality; it's even worse looking than the local deployment. I shouldn't be surprised; the assignment this week was to deploy a backend, not to make a pretty frontend. | ||
|
|
||
| The overall set of Lambda tutorial videos was very good and helpful. It was a clear implementation of our goals and was unambiguous. (I know this is low-hanging fruit, but the other docs I basically read as far as the installation instructions, which was a couple of paragraphs, and didn't have much trouble with troubleshooting them.) That said, I did appreciate the docs for e.g. CORS and dj_database_url which had the installation information right at the top of their' repos' front page. |
There was a problem hiding this comment.
Jonathan, you did a great job with this project. Overall I have no complaints. You worked at a timely pace and got your MVP for this week's project and Sprint finished in a flash. I look forward to seeing what you come up with for next week's project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.