Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not ready pinger #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Jun 16, 2023

  1. check if pod is ready before pinger

    when node crash, kubelet will not update pod status, goldpinger on
    crashed node will not work, but other goldpinger instance will continue
    ping the bad one.
    
    this patch remove the not ready goldpinger instance from pinger list.
    
    ```
    NAME                                READY   STATUS        RESTARTS   AGE
    goldpinger-8749c476d-5n7lt   1/1     Running       0          78d
    goldpinger-8749c476d-bj752   0/1     Terminating   0          78d
    goldpinger-8749c476d-bzf6t   1/1     Running       0          78d
    goldpinger-8749c476d-dv28g   1/1     Running       0          4h25m
    goldpinger-8749c476d-gwhw4   1/1     Running       0          4h25m
    goldpinger-8749c476d-prgwd   1/1     Running       0          78d
    
    {
      "conditions": [
        {
          "lastProbeTime": null,
          "lastTransitionTime": "2023-03-29T12:38:40Z",
          "status": "True",
          "type": "Initialized"
        },
        {
          "lastProbeTime": null,
          "lastTransitionTime": "2023-06-16T02:24:10Z",
          "message": "containers with unready status: [goldpinger]",
          "reason": "ContainersNotReady",
          "status": "False",
          "type": "Ready"
        },
        {
          "lastProbeTime": null,
          "lastTransitionTime": "2023-06-16T02:24:10Z",
          "message": "containers with unready status: [goldpinger]",
          "reason": "ContainersNotReady",
          "status": "False",
          "type": "ContainersReady"
        },
        {
          "lastProbeTime": null,
          "lastTransitionTime": "2023-03-29T12:38:39Z",
          "status": "True",
          "type": "PodScheduled"
        }
      ],
      "containerStatuses": [
        {
          "containerID": "docker://xxx",
          "image": "xxx/goldpinger:v3.5.0",
          "imageID": "docker-pullable://xxx/goldpinger@sha256:xxx",
          "lastState": {},
          "name": "goldpinger",
          "ready": false,
          "restartCount": 0,
          "started": true,
          "state": {
            "running": {
              "startedAt": "2023-03-29T12:38:56Z"
            }
          }
        }
      ],
      "hostIP": "1.2.3.3",
      "phase": "Running",
      "podIP": "1.2.3.4",
      "podIPs": [
        {
          "ip": "1.2.3.4"
        }
      ],
      "qosClass": "Burstable",
      "startTime": "2023-03-29T12:38:40Z"
    }
    ```
    
    Signed-off-by: j4ckstraw <[email protected]>
    j4ckstraw committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    bfd42bd View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. update go.mod and go.sum

    Signed-off-by: j4ckstraw <[email protected]>
    j4ckstraw committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    e570d6c View commit details
    Browse the repository at this point in the history