Remove not ready pinger #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j4ckstraw
force-pushed
the
remove-not-ready-pinger
branch
2 times, most recently
from
b6e175f
to
39285f8
Compare
when node crash, kubelet will not update pod status, goldpinger on
crashed node will not work, but other goldpinger instance will continue
ping the bad one.
this patch remove the not ready goldpinger instance from pinger list.
```
NAME READY STATUS RESTARTS AGE
goldpinger-8749c476d-5n7lt 1/1 Running 0 78d
goldpinger-8749c476d-bj752 0/1 Terminating 0 78d
goldpinger-8749c476d-bzf6t 1/1 Running 0 78d
goldpinger-8749c476d-dv28g 1/1 Running 0 4h25m
goldpinger-8749c476d-gwhw4 1/1 Running 0 4h25m
goldpinger-8749c476d-prgwd 1/1 Running 0 78d
{
"conditions": [
{
"lastProbeTime": null,
"lastTransitionTime": "2023-03-29T12:38:40Z",
"status": "True",
"type": "Initialized"
},
{
"lastProbeTime": null,
"lastTransitionTime": "2023-06-16T02:24:10Z",
"message": "containers with unready status: [goldpinger]",
"reason": "ContainersNotReady",
"status": "False",
"type": "Ready"
},
{
"lastProbeTime": null,
"lastTransitionTime": "2023-06-16T02:24:10Z",
"message": "containers with unready status: [goldpinger]",
"reason": "ContainersNotReady",
"status": "False",
"type": "ContainersReady"
},
{
"lastProbeTime": null,
"lastTransitionTime": "2023-03-29T12:38:39Z",
"status": "True",
"type": "PodScheduled"
}
],
"containerStatuses": [
{
"containerID": "docker://xxx",
"image": "xxx/goldpinger:v3.5.0",
"imageID": "docker-pullable://xxx/goldpinger@sha256:xxx",
"lastState": {},
"name": "goldpinger",
"ready": false,
"restartCount": 0,
"started": true,
"state": {
"running": {
"startedAt": "2023-03-29T12:38:56Z"
}
}
}
],
"hostIP": "1.2.3.3",
"phase": "Running",
"podIP": "1.2.3.4",
"podIPs": [
{
"ip": "1.2.3.4"
}
],
"qosClass": "Burstable",
"startTime": "2023-03-29T12:38:40Z"
}
```
Signed-off-by: j4ckstraw <[email protected]>
j4ckstraw
force-pushed
the
remove-not-ready-pinger
branch
from
39285f8
to
bfd42bd
Compare
Signed-off-by: j4ckstraw <[email protected]>
j4ckstraw
force-pushed
the
remove-not-ready-pinger
branch
from
162f7a5
to
e570d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
do not ping not ready goldpinger instance
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.