forked from gabemansur/Teamwork
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory integration #5
Open
bleonar5
wants to merge
154
commits into
master
Choose a base branch
from
memory_integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 40 commits
Commits
Show all changes
154 commits
Select commit
Hold shift + click to select a range
d5cee32
integrated memory task with waiting room/session setup
bleonar5 1463fb2
fixed instructions bug
bleonar5 48ee215
quick fix to combined memory pilot (typo)
bleonar5 cc7013d
edits requested by Ben for group memory
bleonar5 052695e
edits requested by Ben for group memory
bleonar5 b36c243
edits requested by Ben for group memory
bleonar5 0e250ff
edits requested by Ben for group memory
bleonar5 fe58766
edits requested by Ben for group memory
bleonar5 1051116
edits requested by Ben for group memory
bleonar5 b37c4ab
major timing adjustments on account of design changes (in memory, tim…
bleonar5 91b6da2
final cosmetic adjustments for phase 1 + 2 of memory
bleonar5 298c272
final cosmetic adjustments for phase 1 + 2 of memory
bleonar5 282d15d
final cosmetic adjustments for phase 1 + 2 of memory
bleonar5 043c63f
final cosmetic updates, fixed 'change perspective' button, and update…
bleonar5 5b064ff
final cosmetic updates, fixed 'change perspective' button, and update…
bleonar5 ad1ccd9
changed consent text
bleonar5 fdacab1
added storys timer
bleonar5 21c710c
temporarily removed role_selection page
bleonar5 c15afa8
temporarily removed role_selection page
bleonar5 e4d8d0f
temporarily removed role_selection page
bleonar5 cf5238d
temporarily removed role_selection page
bleonar5 ad6cca5
temporarily removed role_selection page
bleonar5 43c62e3
temporarily removed role_selection page
bleonar5 d60dfcf
temporarily removed role_selection page
bleonar5 8adefc5
temporarily removed role_selection page
bleonar5 e081b7b
temporarily removed role_selection page
bleonar5 6283624
temporarily removed role_selection page
bleonar5 d7c5f5d
fixes to status changes on group memory, fixed lock-unlock functional…
bleonar5 fc6cdab
temporarily removed role_selection page
bleonar5 7043bc1
temporarily removed role_selection page
bleonar5 c4b063a
temporarily removed role_selection page
bleonar5 8292a88
temporarily removed role_selection page
bleonar5 7ed3a49
temporarily removed role_selection page
bleonar5 61c08f5
temporarily removed role_selection page
bleonar5 ac4b5e3
added incognito page and fixed login issues
bleonar5 862f233
added incognito page and fixed login issues
bleonar5 42c3c8d
added incognito page and fixed login issues
bleonar5 77a66b9
added incognito page and fixed login issues
bleonar5 45f97d5
added incognito page and fixed login issues
bleonar5 4f70b23
added incognito page and fixed login issues
bleonar5 5e4e5a2
cosmetic changes and fix for straggler bug
bleonar5 6047fee
individual cosmetic adjustments and minor bug fixes
bleonar5 95ab8cc
individual cosmetic adjustments and minor bug fixes
bleonar5 b09fb6c
individual cosmetic adjustments and minor bug fixes
bleonar5 f1ca11c
individual cosmetic adjustments and minor bug fixes
bleonar5 998d223
individual cosmetic adjustments and minor bug fixes
bleonar5 f963a7d
individual cosmetic adjustments and minor bug fixes
bleonar5 2ff262f
minor fixes to crypto individual
bleonar5 db7eee0
minor fixes to crypto individual
bleonar5 a834ca5
minor fixes to crypto individual
bleonar5 c089a37
leadership edits
bleonar5 446044b
design changes
bleonar5 70e6874
remove device check
bleonar5 e50c649
remove device check
bleonar5 cf6308f
remove device check
bleonar5 c47caaa
remove device check
bleonar5 948d568
remove device check
bleonar5 5280d14
remove device check
bleonar5 26f5096
remove device check
bleonar5 04154ad
remove device check
bleonar5 7acc906
remove device check
bleonar5 5c929cb
remove device check
bleonar5 6bcf674
remove device check
bleonar5 a3ccfc2
added randomization scheme to AssignGroups
bleonar5 2983675
added randomization scheme to AssignGroups
bleonar5 4a9bca9
added randomization scheme to AssignGroups
bleonar5 514a1ca
added randomization scheme to AssignGroups
bleonar5 89b74e6
added randomization scheme to AssignGroups
bleonar5 cc772c7
added randomization scheme to AssignGroups
bleonar5 4be6ed4
added randomization scheme to AssignGroups
bleonar5 ea75b0a
added randomization scheme to AssignGroups
bleonar5 90fb642
added mic level check for device check
bleonar5 535efc8
added mic level check for device check
bleonar5 7565b23
added alt crypto intro timing/text, other fixes and changes
bleonar5 4b607d9
added video feed to devicecheck
bleonar5 f3d1081
fixed device check style
bleonar5 e62fe77
added video feed to devicecheck
bleonar5 8173d6a
added video feed to devicecheck
bleonar5 61a6eab
added video feed to devicecheck
bleonar5 2538f57
added video feed to devicecheck
bleonar5 0d116b4
fixed admin-page timer bug
bleonar5 1f0d73c
added send to conclusion function
bleonar5 6981afb
changed timings and made instruction text dependent on timing variables
bleonar5 ae63e11
changed timings and made instruction text dependent on timing variables
bleonar5 52ff00d
fixed admin-page timer bug
bleonar5 8c30cd6
fixed admin-page timer bug
bleonar5 0d22170
changed timings and made instruction text dependent on timing variables
bleonar5 130996f
changed timings and made instruction text dependent on timing variables
bleonar5 5c16b55
changed timings and made instruction text dependent on timing variables
bleonar5 9c6d1cc
fixed admin-page timer bug
bleonar5 c2843ef
changed css for memory and added individual crypto to end of memory p…
bleonar5 578a294
changed css for memory and added individual crypto to end of memory p…
bleonar5 7357b96
changed css for memory and added individual crypto to end of memory p…
bleonar5 3e64625
edits for phase three link
bleonar5 89dab7c
edits for phase three link
bleonar5 062bafb
edits for phase three link
bleonar5 84b904b
added crypto link
bleonar5 15275e5
added crypto link
bleonar5 1121ee3
yourslef edit
bleonar5 0b605d9
changes to download data
bleonar5 a443d7d
changes to download data
bleonar5 ee6ba16
changes to download data
bleonar5 fd3a9ba
changes to download data
bleonar5 88a2812
changes to download data
bleonar5 a1c2fc5
changes to download data
bleonar5 c8ce05c
changes to download data
bleonar5 55090c9
added rules to individual etc
bleonar5 3037058
git
bleonar5 870cf5a
git
bleonar5 e064802
git
bleonar5 d8c3e3f
added three stage changes
bleonar5 2bf03f4
commit
bleonar5 ccdbf57
git
bleonar5 2f94994
commit
bleonar5 4b5821e
git
bleonar5 d69cfc9
git
bleonar5 717535d
git
bleonar5 20022fc
git
bleonar5 49271bb
git
bleonar5 2eb821e
git
bleonar5 0957912
git
bleonar5 a9779e3
git
bleonar5 c254e2f
git
bleonar5 dbb49f9
git
bleonar5 6a80e54
git
bleonar5 867ef80
git
bleonar5 69d56a6
git
bleonar5 001d20c
git
bleonar5 ee92e4b
git
bleonar5 f6a0de7
git
bleonar5 a1a7834
git
bleonar5 cc0164a
git
bleonar5 7701b59
git
bleonar5 f1f2230
git
bleonar5 91161f0
git
bleonar5 0c3561c
git
bleonar5 b0aeb19
git
bleonar5 64455da
git
bleonar5 f4420d3
git
bleonar5 c34699b
git
bleonar5 5595c5d
git
bleonar5 ace0e8b
git
bleonar5 748ed0b
git
bleonar5 78dee14
git
bleonar5 c4dc45c
git
bleonar5 917176c
git
bleonar5 5192ed3
git
bleonar5 173483d
git
bleonar5 d9fe6c3
git
bleonar5 439a8b7
agora upgrade
bleonar5 c552255
git
bleonar5 482b52b
git
bleonar5 33b4a45
git
bleonar5 fdb666c
git
bleonar5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this all stringified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major holdover from Gabe's design that I chose to integrate rather than rebuild. I think if I had to justify why he did it this way, it's because we have generalized tables for GroupTasks and IndividualTasks, all of which have different subtypes (for instance, cryptography vs memory), and each subtype has some parameters that don't overlap with the other subtypes. So I think in order to avoid a prohibitively wide table and to keep these parameters accessible in a generalized way, he stringified these arrays so he could store them in one column called "parameters"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see okay, thanks for clarifying. Figured that this was a holdover but was curious about it