-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory integration #5
base: master
Are you sure you want to change the base?
Conversation
…ing for each subsession is not uniform
…d group_survey functionality
…d group_survey functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share a little about what the goal of this MR is? It's hard to review this without context
{"taskName":"WaitingRoom","taskParams":{"hasIndividuals":"false","hasGroup":"true","task":"1"}} | ||
]'; | ||
} | ||
|
||
return Self::initializeTasks($group_id, $taskArray, $randomize); | ||
} | ||
|
||
public static function initializeMemoryTasks($group_id, $randomize,$final,$test) { | ||
if($final){ | ||
$taskArray = '[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this all stringified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major holdover from Gabe's design that I chose to integrate rather than rebuild. I think if I had to justify why he did it this way, it's because we have generalized tables for GroupTasks and IndividualTasks, all of which have different subtypes (for instance, cryptography vs memory), and each subtype has some parameters that don't overlap with the other subtypes. So I think in order to avoid a prohibitively wide table and to keep these parameters accessible in a generalized way, he stringified these arrays so he could store them in one column called "parameters"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see okay, thanks for clarifying. Figured that this was a holdover but was curious about it
…ity (no longer interferes with active study to lock login page)
No description provided.