Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emissions cleanup #183

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Emissions cleanup #183

merged 2 commits into from
Jan 5, 2024

Conversation

mootz12
Copy link
Contributor

@mootz12 mootz12 commented Jan 4, 2024 •
edited
Loading

  • Add claim_emissions function for updating and claiming emissions
  • Remove i128 return value from update_emissions due to confusing usage based on flag
  • Add negative number checks and tests

This was linked to issues Jan 4, 2024
BLRC-006 and BLRC-007 and BLRC-009 - Add explicit positive checks to emission calculations #170
Closed
BLRC-008 - Extract claiming flow from update_emissions to a discrete function #171
Closed
Ryang-21
Ryang-21 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@Ryang-21 Ryang-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mootz12 mootz12 merged commit 4d43049 into main Jan 5, 2024
3 checks passed
@mootz12 mootz12 deleted the emissions-cleanup branch January 5, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryang-21 Ryang-21 Ryang-21 approved these changes

@markuspluna markuspluna Awaiting requested review from markuspluna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mootz12 @Ryang-21