New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLRC-008 - Extract claiming flow from update_emissions to a discrete function #171

Closed

mootz12 opened this issue Dec 18, 2023 · 1 comment · Fixed by #183

Assignees

Contributor

mootz12 commented Dec 18, 2023

Claim is currently buried in the emission implementation, causing a confusing interface wherein the return value of a function is unclear.

Consider extracting the claim flow to a separate function to avoid this.

mootz12 self-assigned this

mootz12 linked a pull request

that will close this issue

Emissions cleanup #183

Merged

Contributor Author

mootz12 commented Jan 4, 2024

Opted to just change the module interface to retain the optimization that including the claim flag on update_user_emissions flag brings.

This way, the functions are still easy to test, and don't duplicate excess code, while still making the code paths clear to developers and consumers.

mootz12 closed this as completed in #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment