-
-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start seperating swd multi drop #1184
Conversation
It would be useful please if this PR could be rebased on main, especially now that the J-Link implementation implements those low-level SWD functions mentioned as being a blocker for you. Having proper support for multi-drop and it being refactored like this is of great interest to us |
Thank you for letting me know, this was just the start of the implementation there's work to do still, but I was looking for something to pick up! |
90f0094
to
716da11
Compare
Unsure if ready to merge The context around this PR has changed quite a bit over the time it sat idle, one of the main objectives (J-Link multidrop) was solved in the meantime.
|
ed7d850
to
1b2d9ed
Compare
After taking a new look, this is ready for review @dragonmux it doesn't achieve much worthy of note other than code size (and readability I guess), but, stepping stones... I started to poke the targetsel handling, but I only got higher not lower flash usage and the code didn't improve significantly, so I'm leaving that for another time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great and provides some much needed clean-up and magic number naming - thank you for the contribution!
There are a few items that we've spotted in review that could do with addressing before we merge to try to ensure this is the best possible version of a SWD bus scanner, but with them addressed, we'll be happy to merge this.
This is in preparation to allow non BMP probes to scan multi-drop enabled targets
1b2d9ed
to
7280e82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the contribution! Merging.
We'd run our own tests but we know you're careful to thoroughly test these kinds of thing.
Detailed description
I initially meant to properly abstract away the multidrop handling and swd scan in general, but left it rather early, this PR doesnt have much going for it, just a place to document and later continue work from
as is the jlink scan (and I believe stlink too, but i have not tested or looked at it) does not handle multi-drop, I was meaning to get rp2040 working on jlink as means to develop and test this work but it is unable to comunicate with its DP, the reason is I would guess the Lack of "selection alert sequence for SW-DP-V2" that is present on the regular adiv5_scan
The jlink probe and api should be able to do it, but it needs to be implemented, ideally as a
seq_out
method, and the cmds in jlink in general could do with some worksince the jlink usb spec is not that easy to find I will leave it here
RM08001_JLinkUSBProtocol_Rev.7.pdf
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues