Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: scan return type + swdp naming phase out #1568

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Fix: scan return type + swdp naming phase out #1568

merged 6 commits into from
Jul 28, 2023

Conversation

perigoso
Copy link
Contributor

@perigoso perigoso commented Jul 28, 2023 •
edited
Loading

Detailed description

Followup to #1184

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@perigoso
target: change scan routines return codes to bool
d7de618 
Previously scan routines returned the number of targets probed, this
return count was only used as a scan success/fail check and this can
be made into a simple boolean depicting scan success. Furthermore,
SWD scans returned at most 1 target even when more were detected
@perigoso
command: phase out swdp naming on scan routines
612b283
@perigoso perigoso changed the title Fix/swdp naming phase out Fix: scan retturn type + swdp naming phase out Jul 28, 2023
@perigoso perigoso changed the title Fix: scan retturn type + swdp naming phase out Fix: scan return type + swdp naming phase out Jul 28, 2023
dragonmux
dragonmux requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. There are only two items we spotted in review that need addressing and then this should be good to merge.

Thank you for the contribution!

src/command.c Show resolved Hide resolved
src/include/target.h Outdated Show resolved Hide resolved
@dragonmux dragonmux added this to the v1.10 milestone Jul 28, 2023
@dragonmux dragonmux added the Enhancement General project improvement label Jul 28, 2023
dragonmux
dragonmux approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Nothing super scary here, just a lot of mechanical renaming and return type cleanup.

@dragonmux dragonmux merged commit d16b658 into blackmagic-debug:main Jul 28, 2023
6 checks passed
@perigoso perigoso deleted the fix/swdp-naming-phase-out branch July 28, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonmux dragonmux dragonmux approved these changes

Assignees
No one assigned
Labels
Enhancement General project improvement
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@perigoso @dragonmux