Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-6761] Add fido credentials to data model #657
[PM-6761] Add fido credentials to data model #657
Changes from 2 commits
2aa7f39
fa1abcf
9de626c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 41 in crates/bitwarden/src/vault/cipher/login.rs
Codecov / codecov/patch
crates/bitwarden/src/vault/cipher/login.rs#L41
Check warning on line 43 in crates/bitwarden/src/vault/cipher/login.rs
Codecov / codecov/patch
crates/bitwarden/src/vault/cipher/login.rs#L43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: I'm curious why? Would it move somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely you wouldn't expose this in the view. Instead you fetch the old entry from state and update values on it. That way you don't have to expose encrypted passkeys in the view.
Check warning on line 157 in crates/bitwarden/src/vault/cipher/login.rs
Codecov / codecov/patch
crates/bitwarden/src/vault/cipher/login.rs#L154-L157
Check warning on line 207 in crates/bitwarden/src/vault/cipher/login.rs
Codecov / codecov/patch
crates/bitwarden/src/vault/cipher/login.rs#L189-L207
Check warning on line 209 in crates/bitwarden/src/vault/cipher/login.rs
Codecov / codecov/patch
crates/bitwarden/src/vault/cipher/login.rs#L209