-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-6761] Add fido credentials to data model #657
Conversation
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 60.53% 60.39% -0.15%
==========================================
Files 172 172
Lines 10527 10553 +26
==========================================
Hits 6373 6373
- Misses 4154 4180 +26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my perspective, but I'll let Dani make the final approval
// TODO: Remove this once the SDK supports state | ||
pub fido2_credentials: Option<Vec<Fido2Credential>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ question: I'm curious why? Would it move somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely you wouldn't expose this in the view. Instead you fetch the old entry from state and update values on it. That way you don't have to expose encrypted passkeys in the view.
Type of change
Objective
Add
Fido2Credentials
to theLogin
struct to support storing passkeys. Currently we don't decrypt passkeys but rather pass them along encrypted to ensure we can re-encrypt the login without data loss.Before you submit