Experiment to resolve Gradle issue #14132 with code cov. #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle # trace-sdk/build.gradle
| // Replace the original dependsOn with the filtered | ||
| connectedAndroidTestTask.setDependsOn(deps) | ||
|
|
||
| // Finally make sure that each report task depends on the connected tests. |
There was a problem hiding this comment.
this looks like it's failing the build as it's trying to run the connected tests as well i'm not sure this is accurate - we run the unit tests in the build-trace_sdk workflow and this now fails.
bitrise.yml
Outdated
| @@ -293,10 +293,6 @@ workflows: | |||
| - module: trace-sdk | |||
| - arguments: "--stacktrace" | |||
| title: android_build | |||
| - gradle-runner@1: | |||
There was a problem hiding this comment.
not sure removing the unit tests here is the best idea - possibly just revert the previous workflow step and run the unit tests without coverage? I presume the unit tests then get run later with the coverage at the same time the instrumentation tests run?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.