Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup for dropping legacy modules #21

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: cleanup for dropping legacy modules #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/internal/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,16 +199,6 @@ export class ActionManager {
this.#setActionDefinitions({ actions: hostActions })
}

/** @deprecated */
_getAllActions(): Pick<ActionInstance, 'id' | 'actionId' | 'controlId' | 'options'>[] {
return Array.from(this.#actionInstances.values()).map((act) => ({
id: act.id,
actionId: act.actionId,
controlId: act.controlId,
options: act.options,
}))
}

subscribeActions(actionIds: string[]): void {
let actions = Array.from(this.#actionInstances.values())

Expand Down
10 changes: 0 additions & 10 deletions src/internal/feedback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,16 +420,6 @@ export class FeedbackManager {
}
}

/** @deprecated */
_getAllFeedbacks(): Pick<FeedbackInstance, 'id' | 'feedbackId' | 'controlId' | 'options'>[] {
return Array.from(this.#feedbackInstances.values()).map((fb) => ({
id: fb.id,
feedbackId: fb.feedbackId,
controlId: fb.controlId,
options: fb.options,
}))
}

subscribeFeedbacks(feedbackIds: string[]): void {
let feedbacks = Array.from(this.#feedbackInstances.values())

Expand Down
12 changes: 0 additions & 12 deletions src/module-api/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import type { CompanionFeedbackDefinitions } from './feedback.js'
import type { CompanionPresetDefinitions } from './preset.js'
import type { InstanceStatus, LogLevel } from './enums.js'
import type {
ActionInstance,
ExecuteActionMessage,
FeedbackInstance,
GetConfigFieldsMessage,
GetConfigFieldsResponseMessage,
HandleHttpRequestMessage,
Expand Down Expand Up @@ -535,11 +533,6 @@ export abstract class InstanceBase<TConfig> implements InstanceBaseShared<TConfi
this.#feedbackManager.checkFeedbacksById(feedbackIds)
}

/** @deprecated */
_getAllActions(): Pick<ActionInstance, 'id' | 'actionId' | 'controlId' | 'options'>[] {
return this.#actionManager._getAllActions()
}

/**
* Call subscribe on all currently known placed actions.
* It can be useful to trigger this upon establishing a connection, to ensure all data is loaded.
Expand All @@ -557,11 +550,6 @@ export abstract class InstanceBase<TConfig> implements InstanceBaseShared<TConfi
this.#actionManager.unsubscribeActions(actionIds)
}

/** @deprecated */
_getAllFeedbacks(): Pick<FeedbackInstance, 'id' | 'feedbackId' | 'controlId' | 'options'>[] {
return this.#feedbackManager._getAllFeedbacks()
}

/**
* Call subscribe on all currently known placed feedbacks.
* It can be useful to trigger this upon establishing a connection, to ensure all data is loaded.
Expand Down