Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent redundant candle load calls, & more [1.0.14] #18

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
+213 −599
Open

Fix: Prevent redundant candle load calls, & more [1.0.14] #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ad73131
fix: update onLoadMoreCB if it changes in the Chart react component
f3rno64 Jun 25, 2024
ae6f859
fix: set internal chart ref to null on unmount
f3rno64 Jun 25, 2024
bd5e9b6
fix: prevent redundant calls to onLoadMoreCB
f3rno64 Jun 25, 2024
9925289
feat: bump version to 1.0.14 & build
f3rno64 Jun 25, 2024
790fa44
feat: bump react & react-dom to 18.2.0
f3rno64 Jun 25, 2024
0f2dd86
feat: support arbitrary candle widths in ms, or Bitfinex width strings
f3rno64 Jul 26, 2024
82a928e
feat: add disableTimeFrames prop
f3rno64 Jul 26, 2024
eac5883
fix: remove mouse event listeners in componentWillUnmount
f3rno64 Jul 26, 2024
898ea1a
chore: build
f3rno64 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions dist/Demo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,61 +3,45 @@
Object.defineProperty(exports, "__esModule", {
value: true
});

var _react = require("react");

var _react2 = _interopRequireDefault(_react);

var _reactVirtualized = require("react-virtualized");

var _Chart = require("./components/Chart");

var _Chart2 = _interopRequireDefault(_Chart);

var _btc_candle_data = require("./btc_candle_data.json");

var _btc_candle_data2 = _interopRequireDefault(_btc_candle_data);

require("./Demo.css");

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }

function _interopRequireDefault(e) { return e && e.__esModule ? e : { default: e }; }
function _defineProperty(e, r, t) { return (r = _toPropertyKey(r)) in e ? Object.defineProperty(e, r, { value: t, enumerable: !0, configurable: !0, writable: !0 }) : e[r] = t, e; }
function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol" == typeof i ? i : i + ""; }
function _toPrimitive(t, r) { if ("object" != typeof t || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != typeof i) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
const INDICATORS_STORAGE_KEY = 'bfxc-demo-indicators';
const DEFAULT_INDICATORS_JSON = '[["ema",[20,"close"],["#2da3c4"]],["ema",[100,"close"],["#fcfcba"]],["macd",[12,26,9],["#2acca1","#02f73b","#1073ba"]],["rsi",[14],["#7320bc"]],["mo",[10],["#f8fc0a"]],["acc",[10],["#b4e560"]]]';

_btc_candle_data2.default.sort((a, b) => a[0] - b[0]);

class Demo extends _react2.default.PureComponent {
static loadIndicators() {
if (!localStorage) {
return [];
}

try {
return _Chart2.default.unserializeIndicators(localStorage.getItem(INDICATORS_STORAGE_KEY) || DEFAULT_INDICATORS_JSON);
} catch {
return [];
}
}

constructor(props) {
super(props);

_defineProperty(this, "state", {
drawings: [],
indicators: []
});

this.onUpdateIndicatorArgs = this.onUpdateIndicatorArgs.bind(this);
this.onDeleteIndicator = this.onDeleteIndicator.bind(this);
this.onAddIndicator = this.onAddIndicator.bind(this);
this.onAddDrawing = this.onAddDrawing.bind(this);
this.chartRef = _react2.default.createRef();
this.state.indicators = Demo.loadIndicators();
}

onAddIndicator(i) {
this.setState(({
indicators
Expand All @@ -66,15 +50,13 @@ class Demo extends _react2.default.PureComponent {
}));
this.deferSaveState();
}

onAddDrawing(D) {
this.setState(({
drawings
}) => ({
drawings: [new D(this.chartRef.current.chart), ...drawings]
}));
}

onDeleteIndicator(index) {
this.setState(({
indicators
Expand All @@ -87,7 +69,6 @@ class Demo extends _react2.default.PureComponent {
});
this.deferSaveState();
}

onUpdateIndicatorArgs(args, index) {
this.setState(({
indicators
Expand All @@ -102,24 +83,20 @@ class Demo extends _react2.default.PureComponent {
});
this.deferSaveState();
}

deferSaveState() {
setTimeout(() => {
this.saveState();
}, 0);
}

saveState() {
if (!localStorage) {
return;
}

const {
indicators
} = this.state;
localStorage.setItem(INDICATORS_STORAGE_KEY, _Chart2.default.serializeIndicators(indicators));
}

render() {
const {
drawings,
Expand All @@ -146,7 +123,5 @@ class Demo extends _react2.default.PureComponent {
onAddDrawing: this.onAddDrawing
})));
}

}

exports.default = Demo;
Loading