Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent redundant candle load calls, & more [1.0.14] #18

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

xia-null
Copy link

@xia-null xia-null commented Jun 25, 2024

Does 5 things:

  • bumps react & react-dom to 18.2.0 (prevents multiple react versions in 'consuming' packages using 18.2.0, breaking things)
  • allows <Chart /> component re-mount by setting the internal this.chart reference to null
  • updates the <Chart /> internal this.chart.onLoadMoreCB if the prop changes
  • prevents redundant onLoadMoreCB() calls if the underlying data has not changed since the last call (was spamming on pan)
  • bumps the verison to 1.0.14 & builds.

@xia-null xia-null changed the title Fix: Prevent redundant candle load calls, update load cb in component, allow re-mount [1.0.14] Fix: Prevent redundant candle load calls, & more [1.0.14] Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants