This repository has been archived by the owner on Jan 23, 2024. It is now read-only.
Add code style checks #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
This functionally, this should be ready. However, we already have a merge conflict and presumably many more will occur, with #334 |
|
As the formatting of all these files is automated (i think) we should just accept all incoming changes and rerun the formatting. |
texhnolyze
force-pushed
the
code_style
branch
from
f489220
to
0ae6a60
Compare
by usage of the [pre-commit](https://pre-commit.com/) framework. We are including the following: - `ruff` for fast python linting - `black` for opinionated python auto formatting - `clang-format` for C++ formatting based on google styles - `cppcheck` for C++ linting
that will run and check the pre-commit hooks on PRs and updates on the master branch
texhnolyze
force-pushed
the
code_style
branch
from
0ae6a60
to
7a5244e
Compare
to prevent full repo autoformatting to affect the git history, when utilizing `git blame`
|
I've taken this over cleaned up the history to only have two commits for |
This was referenced Nov 23, 2023
jaagut
approved these changes
Nov 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes