-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] ScoringSheet and ScoringSheetViewer widgets added #6817
Conversation
@ZanMervic, could you check and fix the test errors? For starters, this learner needs to be usable without parameters (just make up some defaults) and needs to be imported in the correct module: https://github.com/biolab/orange3/actions/runs/9328865142/job/25680578428?pr=6817 It should also be somehow obvious that |
0bac02e
to
0257f60
Compare
fd1f721
to
323c5d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6817 +/- ##
==========================================
- Coverage 88.40% 88.38% -0.02%
==========================================
Files 326 329 +3
Lines 71971 72435 +464
==========================================
+ Hits 63624 64023 +399
- Misses 8347 8412 +65 |
With one failing tests I noticed that this learner is not reproducible (the same learner can yields different results in multiple runs). I fixed one test, but this problem could also appear elsewhere. To make this learner behave as other Orange learners, we need to make it reproducible. I tried looking at it, but could not find a quick way to do it. This probably stems from the fasterrisk library. |
Test coverage is relatively low and should be improved in the future. |
Issue
Added Scoring Sheet and Scoring Sheet Viewer widgets (transferred from the prototypes addon).
Description of changes
Notice
One of the additions is the FasterRisk source code, copied from the following repository: https://github.com/jiachangliu/FasterRisk.
This inclusion serves as a temporary solution to address compatibility and functionality issues arising from the strict requirements of the original package. It will remain in place until the original maintainer updates the package to resolve these issues.
Includes