Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] ScoringSheet and ScoringSheetViewer widgets added #6817

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

ZanMervic
Copy link
Contributor

Issue

Added Scoring Sheet and Scoring Sheet Viewer widgets (transferred from the prototypes addon).

Description of changes
  • Transferred two new widgets from the prototypes addon: the Scoring Sheet and Scoring Sheet Viewer.
  • Included documentation and tests for both widgets.
Notice

One of the additions is the FasterRisk source code, copied from the following repository: https://github.com/jiachangliu/FasterRisk.

This inclusion serves as a temporary solution to address compatibility and functionality issues arising from the strict requirements of the original package. It will remain in place until the original maintainer updates the package to resolve these issues.

Includes
  • Code changes
  • Tests
  • Documentation

@markotoplak
Copy link
Member

@ZanMervic, could you check and fix the test errors? For starters, this learner needs to be usable without parameters (just make up some defaults) and needs to be imported in the correct module:

https://github.com/biolab/orange3/actions/runs/9328865142/job/25680578428?pr=6817

It should also be somehow obvious that fasterrisk is not another module with Orange learners. I would suggest making a classification.utils and put fasterrisk there.

@ZanMervic ZanMervic changed the title ScoringSheet and ScoringSheetViewer widgets added [ENH] ScoringSheet and ScoringSheetViewer widgets added Aug 20, 2024
@markotoplak markotoplak added this to the 3.38.0 milestone Oct 21, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 84.41558% with 72 lines in your changes missing coverage. Please review.

Project coverage is 88.38%. Comparing base (9497b39) to head (12bd5a1).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6817      +/-   ##
==========================================
- Coverage   88.40%   88.38%   -0.02%     
==========================================
  Files         326      329       +3     
  Lines       71971    72435     +464     
==========================================
+ Hits        63624    64023     +399     
- Misses       8347     8412      +65     

@markotoplak
Copy link
Member

With one failing tests I noticed that this learner is not reproducible (the same learner can yields different results in multiple runs). I fixed one test, but this problem could also appear elsewhere.

To make this learner behave as other Orange learners, we need to make it reproducible. I tried looking at it, but could not find a quick way to do it. This probably stems from the fasterrisk library.

@markotoplak
Copy link
Member

Test coverage is relatively low and should be improved in the future.

@markotoplak markotoplak merged commit ef3e166 into biolab:master Oct 28, 2024
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants