Implementation and basic unit tests for HEDVersion with libraries #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisLab
changed the title
|
@VisLab @happy5214 This looks great. Node test errors will need to be resolved which should happen with hed validator release, but conceptually I think its solid. |
sappelhoff
changed the title
sappelhoff
changed the title
…validator into hed-library-support
Codecov Report
@@ Coverage Diff @@
## master #1496 +/- ##
==========================================
+ Coverage 83.36% 83.37% +0.01%
==========================================
Files 91 91
Lines 3691 3688 -3
Branches 1123 1122 -1
==========================================
- Hits 3077 3075 -2
+ Misses 518 517 -1
Partials 96 96
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sappelhoff
approved these changes
Aug 29, 2022
|
Thanks @VisLab et al. 🚀 |
sappelhoff
added a commit
that referenced
this pull request
Aug 31, 2022
|
Note: I added a fix in bids-standard/bids-validator@c344e27 HEDVersion had not been updated in the JSON schema (done now, including the regexp). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the bids-validator side of HED library support and is related to:
[ENH] Added the specification for using HED libraries in BIDS bids-specification#1106
which incorporates HED library support into the BIDS specification.
Implement support for library schemas hed-standard/hed-javascript#75
which implements HED JavaScript support for library schemas (@happy5214).
Example of the HED schema library for SCORE implementation bids-examples#324
which contains an example data set using HED library schema version specification (@tpatpa @dorahermes).
The relevant unit tests run with the draft hed-javascript version represented by
hed-standard/hed-javascript#75.
Once this version has been released on npm, the package lock for the
bids-validator will need to be updated, and all of the bids PRs can go forward.
In the meantime, @sappelhoff and @rwblair would you mind looking over and
let us know if you spot any issues?
@happy5214 could you also check that I included everything we discussed?