Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hed library example addition #332

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Hed library example addition #332

merged 2 commits into from
Aug 31, 2022

Conversation

VisLab
Copy link
Member

@VisLab VisLab commented Aug 28, 2022

This addition is in support of bids-standard/bids-specification#1106 and bids-standard/bids-validator#1496.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think it's important that this gets its own example? Or could you imagine editing the already existing eeg_ds003654s_hed example?

I think whenever possible, we should try to work with fewer, rather than more examples.

@VisLab
Copy link
Member Author

VisLab commented Aug 29, 2022

I think for now this needs its own example.  The validation takes a different code path and I think it needs to be tested. 

When the SCORE library 1.0.0 is released, I believe that some of the IEEG examples of @dorahermes @tpatpa will incorporate HED library schema. I decided to put this in over the weekend because I wanted to be sure that the new code paths were tested.

When SCORE stuff gets in, I'll remove this example. I also think the longform example can be consolidated with the base example. I'll consolidate those two examples also when I do the removal. In the meantime, I would appreciate it going in.

@sappelhoff
Copy link
Member

Alright, makes sense to me. I'll wait for the validator to be merged (probably as soon as Ross has time to have a final look) and then we can re-run the CI checks here and merge if they come back green.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now tests are passing on master, as expected 👍

@sappelhoff sappelhoff merged commit bcb658b into bids-standard:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants