Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Add TSV column files #827
[SCHEMA] Add TSV column files #827
Changes from 10 commits
84bfd06
066e2a2
10816d7
19901cd
2a48ef6
2451b9a
de00cea
54458cd
b5754e7
42d6e08
034c6a8
b0b2c3f
4988676
26e8ae9
4615684
27168f5
de9511a
59aea34
a1148c0
02568cf
c3f2558
dc227d6
d831c6c
3955ed4
9b4e8b9
0cb74ee
8d39711
e7db250
3218e8e
3918690
552b4ae
84241d4
bd8c933
9161079
a7356eb
fd54609
efa6fa1
0a4880f
48656fc
7ff360a
de5b5f6
ba84f44
4ba9c25
b510b7d
d562986
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes references to the EEG section here ... but we are in the iEEG section of the spec - so these references don't make sense here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definitions for EEG and iEEG are really different, so I decided to split it into two schema objects. I don't love splitting definitions for the same column in the same file across modalities, so if there's any way to write a single definition that works for both that would be awesome. Do you think it's possible?