-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Add TSV column files #827
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
84bfd06
Add template.
tsalo 066e2a2
Add first column.
tsalo 10816d7
Add columns.
tsalo 19901cd
More terms.
tsalo 2a48ef6
Fill name field in all files.
tsalo 2451b9a
More work.
tsalo de00cea
Merge branch 'master' into tsv-columns-schema
tsalo 54458cd
Add remaining definitions.
tsalo b5754e7
Add macro to render column tables.
tsalo 42d6e08
Fix YAML file.
tsalo 034c6a8
Consolidate suffixes file.
tsalo b0b2c3f
Merge branch 'master' into tsv-columns-schema
tsalo 4988676
Remove old individual files.
tsalo 26e8ae9
Move columns file.
tsalo 4615684
Fix things up a bit.
tsalo 27168f5
Add columns I missed for modality-agnostic TSV files.
tsalo de9511a
Support n/a for duration.
tsalo 59aea34
Apply suggestions from code review
tsalo a1148c0
Code formatting in stim_file definition.
tsalo 02568cf
Allow numbers and strings for value.
tsalo c3f2558
Update src/schema/objects/columns.yaml
tsalo dc227d6
Allow n/a for "z" column.
tsalo d831c6c
Describe meanings of x, y, and z columns.
tsalo 3955ed4
Allow n/a for status column.
tsalo 9b4e8b9
Merge branch 'tsv-columns-schema' of https://github.com/tsalo/bids-sp…
tsalo 0cb74ee
Add participant_id to participants.tsv table and append info for othe…
tsalo 8d39711
Split type definitions into channels and electrodes versions.
tsalo e7db250
Update definitions for group based on file type.
tsalo 3218e8e
Split reference column definition.
tsalo 3918690
Clean up name_channels definition.
tsalo 552b4ae
Draft new columns from #816
tsalo 84241d4
Add new columns to table.
tsalo bd8c933
Merge branch 'master' into tsv-columns-schema
tsalo 9161079
Remove list items.
tsalo a7356eb
Update src/04-modality-specific-files/04-intracranial-electroencephal…
tsalo fd54609
Apply suggestions from code review
tsalo efa6fa1
Use two underscores to delineate multiply-defined columns.
tsalo 0a4880f
Remove text that is now in table.
tsalo 48656fc
Update src/schema/objects/columns.yaml
tsalo 7ff360a
Merge branch 'tsv-columns-schema' of https://github.com/tsalo/bids-sp…
tsalo de5b5f6
Add sections to README on columns file and on reused terms.
tsalo ba84f44
Merge branch 'master' into tsv-columns-schema
tsalo 4ba9c25
Add EDF info to acq_time definition.
tsalo b510b7d
Remove hardcoded tables.
tsalo d562986
Remove unused links.
tsalo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it accurate to say that this macro represents a BIDS rule for the `participants.tsv" file? If so, should this be described in the schema somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the tables do represent rules, but those rules are too complicated to be translated directly from the tables. For more information on the types of mechanisms we need to support in the schema to accurately codify the specification's rules, please see #620.