Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bids 2.0: work out testing against bids-examples #1798

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

yarikoptic
Copy link
Collaborator

To minimize "traffic" on bids-2.0 PR

@yarikoptic yarikoptic force-pushed the bids-2.0-bids-examples branch from a38a379 to 3462ad0 Compare April 19, 2024 21:58
@yarikoptic yarikoptic force-pushed the bids-2.0-bids-examples branch 2 times, most recently from ec75517 to ae152d4 Compare April 19, 2024 23:20
@yarikoptic
Copy link
Collaborator Author

woohoo -- we are green on validate! I thought to add detection and do git mv instead of mv for a good measure... will do that although not sure if it would actually be needed in my next idea: push those into bids-2.0 on bids-examples...

@yarikoptic yarikoptic force-pushed the bids-2.0-bids-examples branch 2 times, most recently from 6d1df23 to 8e4615e Compare April 20, 2024 02:17
@yarikoptic yarikoptic force-pushed the bids-2.0-bids-examples branch from 8e4615e to ba27557 Compare April 20, 2024 03:19
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.50%. Comparing base (0879828) to head (ba27557).

Files Patch % Lines
tools/schemacode/bidsschematools/migrations.py 74.19% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           bids-2.0    #1798      +/-   ##
============================================
- Coverage     88.09%   87.50%   -0.60%     
============================================
  Files            17       17              
  Lines          1579     1432     -147     
============================================
- Hits           1391     1253     -138     
+ Misses          188      179       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic yarikoptic merged commit ba27557 into bids-standard:bids-2.0 Apr 20, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant