Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add warning about deidentification when sharing sourcedata #1769

Merged
merged 5 commits into from
Apr 22, 2024
Merged

[ENH] Add warning about deidentification when sharing sourcedata #1769

merged 5 commits into from
Apr 22, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau requested a review from oesteban April 11, 2024 12:59
Remi-Gau
Remi-Gau commented Apr 11, 2024
View reviewed changes
src/common-principles.md Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (591eebb) to head (97fee7f).
Report is 15 commits behind head on master.

❗ Current head 97fee7f differs from pull request most recent head f9fd169. Consider uploading reports for the commit f9fd169 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1769   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oesteban
oesteban reviewed Apr 12, 2024
View reviewed changes
src/common-principles.md Outdated Show resolved Hide resolved
src/common-principles.md Outdated Show resolved Hide resolved
@Remi-Gau Remi-Gau marked this pull request as ready for review April 15, 2024 09:52
@Remi-Gau Remi-Gau requested review from effigies and sappelhoff April 15, 2024 09:52
This was referenced Apr 15, 2024
Closed
Merged
effigies
effigies reviewed Apr 22, 2024
View reviewed changes
src/common-principles.md Outdated Show resolved Hide resolved
effigies
effigies approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems everyone is in agreement. Green check.

@effigies effigies changed the title Add warning about sharing sourcedata [ENH] Add warning about deidentification when sharing sourcedata Apr 22, 2024
@effigies effigies merged commit 01025da into bids-standard:master Apr 22, 2024
23 of 24 checks passed
@Remi-Gau Remi-Gau deleted the enh/1744 branch October 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericearl ericearl ericearl left review comments

@DimitriPapadopoulos DimitriPapadopoulos DimitriPapadopoulos left review comments

@oesteban oesteban oesteban approved these changes

@effigies effigies effigies approved these changes

@sappelhoff sappelhoff Awaiting requested review from sappelhoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: add some admonition text warning that sharing under sourcedata/ should be done carefully
6 participants
@Remi-Gau @effigies @oesteban @DimitriPapadopoulos @ericearl @sappelhoff