[ENH] Use deidentification consistently in place of anonymization #1799
Conversation
|
#1769 merged. |
src/CHANGES.md
Outdated
| @@ -375,7 +375,7 @@ | |||
| - \[MISC] Typo and style [#378](https://github.com/bids-standard/bids-specification/pull/378) ([TheChymera](https://github.com/TheChymera)) | |||
| - \[FIX] divide readme into 3 parts [#374](https://github.com/bids-standard/bids-specification/pull/374) ([sappelhoff](https://github.com/sappelhoff)) | |||
| - \[FIX] Refer to BIDS consistently, instead of "\<Modality>-BIDS" [#366](https://github.com/bids-standard/bids-specification/pull/366) ([sappelhoff](https://github.com/sappelhoff)) | |||
| - \[FIX] Change recommended anonymization date from 1900 to 1925 [#363](https://github.com/bids-standard/bids-specification/pull/363) ([alexrockhill](https://github.com/alexrockhill)) | |||
| - \[FIX] Change recommended deidentification date from 1900 to 1925 [#363](https://github.com/bids-standard/bids-specification/pull/363) ([alexrockhill](https://github.com/alexrockhill)) | |||
There was a problem hiding this comment.
We should not modify CHANGES.md. If there's a typo in a PR, we can edit the PR and it will get updated next time the changelog generator is run. In this case, I think it's okay to leave, since it accurately describes the PR.
There was a problem hiding this comment.
PR #363 is precisely about deidentififcation, not anonymisation - shifting dates so that "chances of identifying a person based on the date and time of their scan would be decreased". I have actually modified the paragraph modified by #363:
With that said, perhaps it is not worth chasing down this occurrence of anonymisation.
DimitriPapadopoulos
force-pushed
the
anonymisation_deidentification
branch
from
1febb47 to
2faf00b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1799 +/- ##
=======================================
Coverage 87.92% 87.92%
=======================================
Files 16 16
Lines 1375 1375
=======================================
Hits 1209 1209
Misses 166 166 ☔ View full report in Codecov by Sentry. |
DimitriPapadopoulos
force-pushed
the
anonymisation_deidentification
branch
from
2faf00b to
e9db606
Compare
In the vast majority of cases, strict anonymisation is impossible. Use the more generic term deidentification instead.
DimitriPapadopoulos
force-pushed
the
anonymisation_deidentification
branch
from
e9db606 to
fcfcb37
Compare
effigies
changed the title
In the vast majority of cases, strict anonymisation is impossible. Use the more generic term deidentification instead.
I suggest #1769 is merged first, then I can rebase and fix all occurrences.
Fixes #1782.