-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Define the types present in the schema in a new YAML file #1048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
+ Coverage 88.09% 92.22% +4.13%
==========================================
Files 6 10 +4
Lines 974 1145 +171
==========================================
+ Hits 858 1056 +198
+ Misses 116 89 -27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
src/schema/objects/types.yaml
Outdated
name: Metadata Field | ||
description: | | ||
A field that may be present in a BIDS sidecar JSON file. | ||
definition: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the most extensive "definition," so I think it's the best one to focus on as we determine if this structure is any good.
Feels out of scope for the current sprint. We will not likely parse this in any first implementations, but might be worth revisiting once the schema is finalized. |
src/schema/meta/types.yaml
Outdated
- format | ||
- unit | ||
- enum | ||
- pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I define these and other fields in this file as well?
Closes None, but it might be related to #884?
Changes proposed:
schema/objects/types.yaml
file with definitions of the valid "object types" (e.g., suffixes, metadata fields) within the schema. This gives each a name and description.To do: