Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'modality' to glossary #1141

Closed
CPernet opened this issue Jul 13, 2022 · 5 comments · May be fixed by #1237
Closed

add 'modality' to glossary #1141

CPernet opened this issue Jul 13, 2022 · 5 comments · May be fixed by #1237

Comments

@CPernet
Copy link
Collaborator

CPernet commented Jul 13, 2022

I've seen the word 'modality' used in different context, for instance /anat and /func defined as 2 (MRI) modalities. Within BIDS, these are not since under 'Modality specific files', what is listed is different data types based on technology.

Proposal: a modality corresponds to a technology-driven data type (MRI, MEG, EEG, Behaviour, Eye tracking, etc) and does not separate within modality (e.g. anat vs. func).

@tsalo
Copy link
Member

tsalo commented Jul 13, 2022

"anat" and "func" are, I believe, datatypes, rather than modalities. We have a modalities.yaml within the schema that lists the modalities in BIDS.

In #593, we have discussed renaming "modality" to something like "technology" or "instrument".

In #1048, I have proposed adding a new schema file that describes the other files in the schema, including "modalities". This would automatically add these terms to the glossary.

There have been discussions about adding common principles to the schema (e.g., here), which would also include "modality".

@CPernet
Copy link
Collaborator Author

CPernet commented Jul 15, 2022

ah of course @robertoostenveld was on the case :-)

Having browsed the different items mentioned above, I do see an issue with name inconsistency I do like your proposal 593 with instruments and data types +1

The spec tree would therefore organize along those two names, with data types as top-level folders for data. What happens to the word modality after that?

@robertoostenveld
Copy link
Collaborator

You may want to have a look at some of my notes that relate to this, see my BIDS bigger picture google doc. It aims to clarify instruments, modalities and suffixes.

@CPernet
Copy link
Collaborator Author

CPernet commented Jul 15, 2022

I did :-) and instrument/data type sounds good to me (still not defining what modality would be after that)

@yarikoptic
Copy link
Collaborator

we have two "types" of modality (term and "entity") listed in Glossary already:

so this issue is IMHO is resolved. For more discussion on possible future changes relating to modality, see e.g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants