Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freesurfer segmentation results extraction activity example BIDS-Prov #60

Open
wants to merge 160 commits into
base: master
Choose a base branch
from

Conversation

dbkeator
Copy link

See README.md file for additional information. This is an example derived from ABIDE NIDM files containing Freesurfer segmentation statistics.

remiadon and others added 27 commits February 18, 2021 18:43
Copy link
Contributor

@remiadon remiadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmaumet I make a few comments on this PR. There are relayed to the discussion we are having in the google doc

But this PR adds an interesting example to the ones we already have !

"freesurfer:Title": "Segmentation Statistics",
"freesurfer:VoxelVolume_mm3": "1",
"freesurfer:anatomy_type": "volume",
"freesurfer:cmdline": "mri_segstats --seg mri/aseg.mgz --sum stats/aseg.stats --pv mri/norm.mgz --empty --brainmask mri/brainmask.mgz --brain-vol-from-seg --excludeid 0 --excl-ctxgmwm --supratent --subcortgray --in mri/norm.mgz --in-intensity-name norm --in-intensity-units MR --etiv --surf-wm-vol --surf-ctx-vol --totalgray --euler --ctab /opt/freesurfer-6.0.0-min/ASegStatsLUT.txt --subject sub-0050660",
Copy link
Contributor

@remiadon remiadon Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A command field has been added (as REQUIRED) in the definition of a Activity from our gdoc

So I guess freesurfer:cmdline should be renamed command and placed above (eg. after startedAtTime)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, will make the change....

"@id": "niiri:ff2754fe-1585-11eb-b1e7-1094bbf2086c",
"description": "Freesurfer segmentation statistics",
"startedAtTime": "2018-11-27T21:42:49",
"wasAttributedTo": "RRID:SCR_001847",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we used wasAssociatedWith to record the fact that an activity is a running instance of an Agent

an example here

And the def of this term in our common context here

@cmaumet
Copy link
Collaborator

cmaumet commented May 21, 2024

(Note for @bclenet: let's keep this PR open as it is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants