Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new target EASP-RRIOTF722 #1278

Closed
wants to merge 5 commits into from

Conversation

ws998116
Copy link

No description provided.

@ws998116 ws998116 requested a review from a team as a code owner March 18, 2024 14:55
@nerdCopter
Copy link
Member

nerdCopter commented Mar 18, 2024

  • is it possible to add the timer and dma comments similar to other existing targets? (does not affect usage/merging, just an unimportant request).
  • they can be output by flashing 4.5 with the USE_TIMER_MAP_PRINT custom define, then executing timer and dma in CLI.

@ws998116
Copy link
Author

Thanks @nerdCopter, fixed.

@nerdCopter
Copy link
Member

@haslinghuis , does line 1 need to be a Betaflight version?

nerdCopter
nerdCopter previously approved these changes Mar 19, 2024
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging - we need #1277

@ws998116
Copy link
Author

ws998116 commented Apr 2, 2024

Please leave this open for now, there will be some changes.

@nerdCopter nerdCopter marked this pull request as draft April 2, 2024 13:04
Copy link

github-actions bot commented May 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@ot0tot
Copy link
Contributor

ot0tot commented May 12, 2024

Is there a typo in the config? Gyro, flash, OSD, and baro should not all be on the same SPI bus.

@ws998116
Copy link
Author

@ot0tot we are moving the baro to I2C, but the rest will share SPI.

@ot0tot
Copy link
Contributor

ot0tot commented May 13, 2024

@ot0tot we are moving the baro to I2C, but the rest will share SPI.

Can you move flash and OSD to their own SPI bus? You cannot have all of these perepherials on the same bus.

@ws998116
Copy link
Author

@ot0tot are you suggesting to have three separate SPI buses? One for each peripheral?

@ot0tot
Copy link
Contributor

ot0tot commented May 13, 2024

@ot0tot are you suggesting to have three separate SPI buses? One for each peripheral?

Correct. Refer to other similar target configs for examples.

@haslinghuis
Copy link
Member

Closing as we no longer accept new unified targets. Please create a config in https://github.com/betaflight/config repo with requested SPI assignments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants