Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New translations #166

Merged
merged 8 commits into from
Jul 15, 2024
Merged

New translations #166

merged 8 commits into from
Jul 15, 2024

Conversation

SanjeevLakhwani
Copy link
Contributor

No description provided.

davidlougheed
davidlougheed requested changes Jun 13, 2024
View reviewed changes
src/js/components/Search/SearchResultsPane.tsx Outdated Show resolved Hide resolved
src/public/locales/fr/translation_fr.json Outdated Show resolved Hide resolved
src/public/locales/en/translation_en.json Outdated Show resolved Hide resolved
@SanjeevLakhwani SanjeevLakhwani self-assigned this Jun 17, 2024
davidlougheed
davidlougheed previously requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the translations have the same indent level

@SanjeevLakhwani SanjeevLakhwani requested review from davidlougheed and v-rocheleau and removed request for davidlougheed June 17, 2024 19:45
@SanjeevLakhwani SanjeevLakhwani dismissed davidlougheed’s stale review June 20, 2024 17:27

on vacation. issues are resolved.

@SanjeevLakhwani SanjeevLakhwani requested review from davidlougheed and removed request for davidlougheed June 20, 2024 17:28
v-rocheleau
v-rocheleau requested changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only noticed an issue with the "in" translation.
By default we translate "in" => "dans", but this is grammatically incorrect in the Search context, where we have:

  • "Age (in years)" => "Âge(dans years)"
    • should be "Âge (en années)"
  • "Lab Test Results (in mg/L) => Résultats des tests de laboratoire (dans mg/L)"
    • should be "Résultats des tests de laboratoire (en mg/L)"

v-rocheleau
v-rocheleau requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close to being ok, there is still an issue with the "years" translation however:
image
This should be "(en années)"

v-rocheleau
v-rocheleau approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept having the "en years" issue because I was using Bento's default translation file in lib/public/translations. After merging this we should update the default translations in the Bento repo.

@davidlougheed davidlougheed merged commit fb80193 into main Jul 15, 2024
2 checks passed
@davidlougheed davidlougheed deleted the new-translations branch August 26, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau v-rocheleau approved these changes

@davidlougheed davidlougheed davidlougheed left review comments

@gsfk gsfk Awaiting requested review from gsfk

Assignees

@SanjeevLakhwani SanjeevLakhwani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SanjeevLakhwani @davidlougheed @v-rocheleau