category on UIViewController #2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // | ||
| // UIViewController+BAPromise.h | ||
| // BAPromise | ||
| // | ||
| // Created by Ben Allison on 4/21/16. | ||
| // Copyright © 2016 Ben Allison. All rights reserved. | ||
| // | ||
|
|
||
| #import <UIKit/UIKit.h> | ||
|
|
||
| @interface UIViewController (BAPromise) | ||
|
|
||
| @end | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // | ||
| // UIViewController+BAPromise.m | ||
| // BAPromise | ||
| // | ||
| // Created by Ben Allison on 4/21/16. | ||
| // Copyright © 2016 Ben Allison. All rights reserved. | ||
| // | ||
|
|
||
| #import "UIViewController+BAPromise.h" | ||
| #import "BAPromiseClient.h" | ||
|
|
||
| @implementation UIViewController (BAPromise) | ||
|
|
||
| -(BAPromise *)promise_DismissViewControllerAnimated:(BOOL)animated | ||
|
There was a problem hiding this comment. nitpick here but you are using snake_case for first part of ...present... below :-) |
||
| { | ||
| BAPromiseClient *promise = BAPromiseClient.new; | ||
| if (!self.presentedViewController) { | ||
| // TODO(benski) a better error | ||
| return [promise rejectedPromise:[NSError errorWithDomain:@"org.benski.promise" code:0 info:nil]]; | ||
| } | ||
|
|
||
| [self dismissViewControllerAnimated:animated completion:^{ | ||
| [promise fulfil]; | ||
|
There was a problem hiding this comment. is this a typo? Now i'm forgetting how to spell it |
||
| }]; | ||
| return promise; | ||
| } | ||
|
|
||
| -(BAPromise *)promise_presentViewController:(UIViewController *)controller | ||
| animated:(BOOL)animated | ||
| { | ||
| BAPromiseClient *promise = BAPromiseClient.new; | ||
| [self presentViewController:controller animated:YES completion:^{ | ||
| [promise fullfil]; | ||
| }]; | ||
| return promise; | ||
| } | ||
|
|
||
| - (BAPromise<NSNumber *> *)transitionFromViewController:(UIViewController *)fromViewController toViewController:(UIViewController *)toViewController duration:(NSTimeInterval)duration options:(UIViewAnimationOptions)options animations:(void (^ __nullable)(void))animations completion:(void (^ __nullable)(BOOL finished))completion | ||
|
There was a problem hiding this comment. would recommend line breaks on fields for this one :-) |
||
| { | ||
| BAPromiseClient *promise = BAPromiseClient.new; | ||
| [self transitionFromViewController:fromViewController | ||
| toViewController:toViewController | ||
| duration:duration | ||
| options:options | ||
| animations:animations | ||
| completion:^(BOOL finished) { | ||
| [promise fulfillWithObject:@(finished)]; | ||
| }]; | ||
| return promise; | ||
| } | ||
|
|
||
| @end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hah!
oh it would help if i added the methods to the interface file