-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
category on UIViewController #2
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,13 @@ | |||
// | |||
// UIViewController+BAPromise.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hah!
oh it would help if i added the methods to the interface file
return promise; | ||
} | ||
|
||
- (BAPromise<NSNumber *> *)transitionFromViewController:(UIViewController *)fromViewController toViewController:(UIViewController *)toViewController duration:(NSTimeInterval)duration options:(UIViewAnimationOptions)options animations:(void (^ __nullable)(void))animations completion:(void (^ __nullable)(BOOL finished))completion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would recommend line breaks on fields for this one :-)
|
||
@implementation UIViewController (BAPromise) | ||
|
||
-(BAPromise *)promise_DismissViewControllerAnimated:(BOOL)animated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick here but you are using snake_case for first part of ...present... below :-)
rockin idea, do you think it would be good to also include present/dismissModalViewController |
No description provided.