-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRAD2-2768 #348
Merged
Merged
GRAD2-2768 #348
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
132e26b
Added an extra type hierarchy for school events for filtering on tran…
dd34f32
Added some unit tests to support history filtering on school created …
7b3e35e
Added testing for school updated
5659c42
Added testing and code for move school filtering
709db5f
Added rules for UPDATE_SCHOOL_CONTACT
96606fe
Removed old update event with history method.
e43521e
Merge branch 'refs/heads/grad-release' into GRAD2-2768
b729386
Updated gitignore
8f9096d
initial commit
47f72e6
Added endpoint for searching event history.
d9da5cc
Added openapi specs
08909da
Added a mapper
41819a4
Added json ignore to prevent infinite recursion
df10472
Changed to Event, also updated pom to include mapstruct annotation pr…
874003b
Still buggered mapper
a453013
Success with mapper
c677112
Updated test file and pom
21717e2
Updated exclusion for mapper
cc07256
Updated exclusion for filter
3e948ca
Adding unit testing for service
f3d3ab5
Increasing test coverage.
2b185fe
Merge branch 'refs/heads/grad-release' into GRAD2-2768
af8eddf
Increasing test coverage.
bcd13ef
Including for test
4bd315b
Including mapper tests
cef7a35
Added update endpoint and service method
40b5b15
Added tests and validation for EventHistory
9e561c4
Finished integration testing
a60408b
Excluding filter
b1561ec
Added validation response formatter and increased testing on UUIDMapper
75cba22
Added routes to student admin
4103ba2
Updated EntityNotFound handler
45c9372
Cleaning up code
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,5 +54,5 @@ build/ | |
### VS Code ### | ||
.vscode/ | ||
|
||
### local dev ### | ||
### Local dev ### | ||
**/application-local.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the second EntityNotFound handler, but covers DataRetrievalFailure.
Also DataRetrievalFailure is more related to the server side 500 group of errors and returning of BAD_REQUEST is confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I merged the two and return a 404. The EntityNotFoundException is the only one explicitly thrown to state that an object is not found in the DB, while the other exceptions are from Spring JPA but also denote not found.