GRAD2-2768 #348
Merged
GRAD2-2768 #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 15, 2024 09:33
…script eligibility
# Conflicts: # api/src/main/java/ca/bc/gov/educ/api/trax/service/SchoolEventBaseService.java
arybakov-cgi
suggested changes
Sep 9, 2024
| protected ResponseEntity<Object> handleEntityNotFound(RuntimeException ex, WebRequest request) { | ||
| LOGGER.error("JPA ERROR IS: " + ex.getClass().getName(), ex); | ||
| protected ResponseEntity<Object> handleEntityNotFound(RuntimeException ex) { | ||
| log.error("JPA ERROR IS: {}", ex.getClass().getName(), ex); | ||
| validation.clear(); | ||
| return new ResponseEntity<>(ApiResponseModel.ERROR(null, ex.getLocalizedMessage()), HttpStatus.BAD_REQUEST); | ||
| } |
There was a problem hiding this comment.
This is the second EntityNotFound handler, but covers DataRetrievalFailure.
Also DataRetrievalFailure is more related to the server side 500 group of errors and returning of BAD_REQUEST is confusing.
There was a problem hiding this comment.
Agree. I merged the two and return a 404. The EntityNotFoundException is the only one explicitly thrown to state that an object is not found in the DB, while the other exceptions are from Spring JPA but also denote not found.
|
arybakov-cgi
approved these changes
Sep 9, 2024
cditcher
pushed a commit
that referenced
this pull request
Sep 10, 2024
This reverts commit 6a6bea1.
cditcher
pushed a commit
that referenced
this pull request
Sep 20, 2024
This reverts commit e304bb7.
cditcher
added a commit
that referenced
this pull request
Oct 3, 2024
* Adding bruno files * Increased meta space to help mitigate OOMKills * Revert "Revert "GRAD2-2768 (#348)"" This reverts commit e304bb7. * Fixing configmap. * Updating metaspace. --------- Co-authored-by: chris.ditcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.