feat: nlohmann_json add single_include package #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @keith, modules you maintain (nlohmann_json) have been updated in this PR. Please review the changes. |
lromor
changed the title
lromor
force-pushed
the
add-nlohmann-json-multi-header
branch
6 times, most recently
from
25ff0a3
to
106bfb5
Compare
lromor
changed the title
|
I'd put it in the toplevel BUILD file. Keep the original Reasoning: for projects that also support the 'old' WORKSPACE file, they have a simple way to provide a toplevel BUILD file, but not a nested structure. A project that needs to compile with before and after bzlmod should be able to do that easily. Example of such a project and how it will be working nicely with a toplevel target : chipsalliance/verible#2268 |
lromor
force-pushed
the
add-nlohmann-json-multi-header
branch
2 times, most recently
from
7b71bd4
to
a26590b
Compare
|
LGTM |
|
I guess @keith needs to add a review ? |
keith
reviewed
Oct 3, 2024
modules/nlohmann_json/3.11.3.bcr.1/patches/add_singleheader_target.patch
Outdated
Show resolved
Hide resolved
|
i think we should avoid |
lromor
force-pushed
the
add-nlohmann-json-multi-header
branch
from
a26590b
to
55de76b
Compare
keith
previously approved these changes
Oct 9, 2024
keith
reviewed
Oct 9, 2024
keith
previously approved these changes
Oct 9, 2024
bazel-io
dismissed stale reviews from keith and keith
Require module maintainers' approval for newly pushed changes.
keith
reviewed
Oct 9, 2024
keith
reviewed
Oct 9, 2024
keith
approved these changes
Oct 9, 2024
hzeller
added a commit
to hzeller/verible
that referenced
this pull request
Oct 11, 2024
We used to patch the module to allow the single header version of the library to be available. Not needed anymore thanks to @lromor who added it in BCR in bazelbuild/bazel-central-registry#2865 Now, use the same name for the old-WORKSPACE based build and the new MODULE based build.
hzeller
added a commit
to hzeller/verible
that referenced
this pull request
Oct 11, 2024
We used to patch the module to allow the single header version of the library to be available. Not needed anymore thanks to @lromor who added it in BCR in bazelbuild/bazel-central-registry#2865 Now, use the same name for the old-WORKSPACE based build and the new MODULE based build. While at it: fix formatting in MODULE.bazel.
hzeller
added a commit
to hzeller/verible
that referenced
this pull request
Oct 11, 2024
We used to patch the module to allow the single header version of the library to be available. Not needed anymore thanks to @lromor who added it in BCR in bazelbuild/bazel-central-registry#2865 Now, use the same name for the old-WORKSPACE based build and the new MODULE based build; for that the name we provide in bazel/jsonhpp.BUILD, and all uses in the repo, had to be changed. While at it: fix formatting in MODULE.bazel.
hzeller
added a commit
to hzeller/verible
that referenced
this pull request
Oct 11, 2024
We used to patch the module to allow the single header version of the library to be available. Not needed anymore thanks to @lromor who added it in BCR in bazelbuild/bazel-central-registry#2865 Now, use the same name for the old-WORKSPACE based build and the new MODULE based build; for that the name we provide in bazel/jsonhpp.BUILD, and all uses in the repo, had to be changed. While at it: fix formatting in MODULE.bazel.
hzeller
added a commit
to hzeller/verible
that referenced
this pull request
Oct 11, 2024
We used to patch the module to allow the single header version of the library to be available. Not needed anymore thanks to @lromor who added it in BCR in bazelbuild/bazel-central-registry#2865 Now, use the same name for the old-WORKSPACE based build and the new MODULE based build; for that the name we provide in bazel/jsonhpp.BUILD, and all uses in the repo, had to be changed. While at it: fix formatting in MODULE.bazel.
asa
pushed a commit
to asa/bazel-central-registry
that referenced
this pull request
Oct 27, 2024
nlohmann_json provides a new single-header target. Add it as optional target to the the bazel module. --------- Co-authored-by: Keith Smiley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nlohmann_json provides a new single-header target. Add it as optional target to the the bazel module.