Use new @jsonhpp//:singleheader-json also available in 3.11.3.bcr.1 #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
force-pushed
the
feature-20241011-singleheader-json
branch
3 times, most recently
from
efd6695
to
f05ee1d
Compare
We used to patch the module to allow the single header version of the library to be available. Not needed anymore thanks to @lromor who added it in BCR in bazelbuild/bazel-central-registry#2865 Now, use the same name for the old-WORKSPACE based build and the new MODULE based build; for that the name we provide in bazel/jsonhpp.BUILD, and all uses in the repo, had to be changed. While at it: fix formatting in MODULE.bazel.
hzeller
force-pushed
the
feature-20241011-singleheader-json
branch
from
f05ee1d
to
75f3cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to patch the module to allow the single header version of the library to be available. Not needed anymore thanks to @lromor who added it in BCR in
bazelbuild/bazel-central-registry#2865
Now, use the same name for the old-WORKSPACE based build and the new MODULE based build.