Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape secrets in inline command substitution #1008

Closed
wants to merge 1 commit into from
Closed

Escape secrets in inline command substitution #1008

wants to merge 1 commit into from

Commits on Sep 30, 2024

  1. Escape secrets in inline command substitution 

    Kamal "inlines" calls to `kamal secrets` in the dotenv file, but the
results of the calls were not being escaped properly. To "fix" this
`kamal secrets fetch` escaped the JSON string before returning it.

The two errors cancelled out, but it meant that the commands didn't
work from a shell.

To fix, we'll escape the inline command results and remove the escaping
from `kamal secrets fetch`.
    @djmb
    djmb committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ff24fd9 View commit details
    Browse the repository at this point in the history