Escape secrets in inline command substitution #1008
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kamal "inlines" calls to
kamal secrets
in the dotenv file, but the results of the calls were not being escaped properly. To "fix" thiskamal secrets fetch
escaped the JSON string before returning it.The two errors cancelled out, but it meant that the commands didn't work from a shell.
To fix, we'll escape the inline command results and remove the escaping from
kamal secrets fetch
.Fixes #1007