feat: extra nameCN for character & person #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我记得有个相关的 issue |
|
#810 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 69.14% 68.95% -0.19%
==========================================
Files 98 107 +9
Lines 15242 16138 +896
Branches 799 859 +60
==========================================
+ Hits 10539 11128 +589
- Misses 4694 5001 +307
Partials 9 9 ☔ View full report in Codecov by Sentry. |
|
这个是不是数据库没有单独一列啊？ |
|
是的，没有 |
|
这个是解析了一遍对应角色的infobox出来的？ |
|
感觉应该考虑以后加一列，现在先这样吧 |
|
有一个叫 |
|
那是不是应该从那个表里读啊 🤔 |
|
看了下代码，这个表里的内容好像只是拿来搜索的 |
|
那还是等着后面加一列吧 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.