feat: extra nameCN for character & person (#846)

bangumi · Dec 1, 2024 · 409ab9a · 409ab9a
1 parent 8904e5a
commit 409ab9a
Show file tree

Hide file tree

Showing 7 changed files with 38 additions and 2 deletions.
diff --git a/lib/types/convert.ts b/lib/types/convert.ts
@@ -20,6 +20,10 @@ export function splitTags(tags: string): string[] {
     .filter((x) => x !== '');
 }
 
+export function extractNameCN(infobox: res.IInfobox): string {
+  return infobox.find((x) => ['中文名', '简体中文名'].includes(x.key))?.values[0]?.v ?? '';
+}
+
 export function toSubjectTags(tags: string): res.ISubjectTag[] {
   if (!tags) {
     return [];
@@ -290,9 +294,11 @@ export function toSubjectEpStatus(
 }
 
 export function toSlimCharacter(character: orm.ICharacter): res.ISlimCharacter {
+  const infobox = toInfobox(character.infobox);
   return {
     id: character.id,
     name: character.name,
+    nameCN: extractNameCN(infobox),
     role: character.role,
     images: personImages(character.img) || undefined,
     nsfw: character.nsfw,
@@ -301,11 +307,13 @@ export function toSlimCharacter(character: orm.ICharacter): res.ISlimCharacter {
 }
 
 export function toCharacter(character: orm.ICharacter): res.ICharacter {
+  const infobox = toInfobox(character.infobox);
   return {
     id: character.id,
     name: character.name,
+    nameCN: extractNameCN(infobox),
     role: character.role,
-    infobox: toInfobox(character.infobox),
+    infobox: infobox,
     summary: character.summary,
     images: personImages(character.img) || undefined,
     comment: character.comment,
@@ -317,9 +325,11 @@ export function toCharacter(character: orm.ICharacter): res.ICharacter {
 }
 
 export function toSlimPerson(person: orm.IPerson): res.ISlimPerson {
+  const infobox = toInfobox(person.infobox);
   return {
     id: person.id,
     name: person.name,
+    nameCN: extractNameCN(infobox),
     type: person.type,
     images: personImages(person.img) || undefined,
     nsfw: person.nsfw,
@@ -328,6 +338,7 @@ export function toSlimPerson(person: orm.IPerson): res.ISlimPerson {
 }
 
 export function toPerson(person: orm.IPerson): res.IPerson {
+  const infobox = toInfobox(person.infobox);
   const career = [];
   if (person.producer) {
     career.push('producer');
@@ -356,8 +367,9 @@ export function toPerson(person: orm.IPerson): res.IPerson {
   return {
     id: person.id,
     name: person.name,
+    nameCN: extractNameCN(infobox),
     type: person.type,
-    infobox: toInfobox(person.infobox),
+    infobox: infobox,
     career,
     summary: person.summary,
     images: personImages(person.img) || undefined,

diff --git a/lib/types/res.ts b/lib/types/res.ts
@@ -298,6 +298,7 @@ export const Character = t.Object(
   {
     id: t.Integer(),
     name: t.String(),
+    nameCN: t.String(),
     role: t.Integer(),
     infobox: t.Ref(Infobox),
     summary: t.String(),
@@ -320,6 +321,7 @@ export const SlimCharacter = t.Object(
   {
     id: t.Integer(),
     name: t.String(),
+    nameCN: t.String(),
     role: t.Integer(),
     images: t.Optional(t.Ref(PersonImages)),
     lock: t.Boolean(),
@@ -337,6 +339,7 @@ export const Person = t.Object(
   {
     id: t.Integer(),
     name: t.String(),
+    nameCN: t.String(),
     type: t.Integer(),
     infobox: t.Ref(Infobox),
     career: t.Array(t.String(), {
@@ -363,6 +366,7 @@ export const SlimPerson = t.Object(
   {
     id: t.Integer(),
     name: t.String(),
+    nameCN: t.String(),
     type: t.Integer(),
     images: t.Optional(t.Ref(PersonImages)),
     lock: t.Boolean(),

diff --git a/routes/__snapshots__/index.test.ts.snap b/routes/__snapshots__/index.test.ts.snap
diff --git a/routes/private/routes/__snapshots__/character.test.ts.snap b/routes/private/routes/__snapshots__/character.test.ts.snap
diff --git a/routes/private/routes/__snapshots__/person.test.ts.snap b/routes/private/routes/__snapshots__/person.test.ts.snap
diff --git a/routes/private/routes/__snapshots__/subject.test.ts.snap b/routes/private/routes/__snapshots__/subject.test.ts.snap
diff --git a/routes/private/routes/__snapshots__/user.test.ts.snap b/routes/private/routes/__snapshots__/user.test.ts.snap