Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update renovate config #1495

Merged
4 commits merged into from
Nov 18, 2024
Merged

Update renovate config #1495

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71008cc
renovate: Avoid rebasing failing PRs
thgreasi Nov 15, 2024
8a71533
renovate: Set prHourlyLimit to 1
thgreasi Nov 15, 2024
aed1092
renovate: Drop the custom rule for majors in favor of the global setting
thgreasi Nov 15, 2024
545bf72
renovate: Block updating majors & minors of balena-hup-action-utils
thgreasi Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
{
"extends": ["github>balena-io/renovate-config"],
"prConcurrentLimit": 1,
"prHourlyLimit": 1,
"rebasewhen": "automerge",
"packageRules": [
{
"matchUpdateTypes": ["major", "minor", "patch", "digest"],
"automerge": false,
"labels": ["renovate", "dependencies", "{{depType}}", "major"]
"matchPackageNames": ["balena-hup-action-utils"],
"matchUpdateTypes": [
"major",
"minor"
],
"enabled": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want renovate to never open a PR for this, or would you like it to open a PR for convenience but never rebase it and disable automerge?

Copy link
Member Author

@thgreasi thgreasi Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a major or a minor, which has a dependency of the proxy being bumped & deployed first, I think it makes sense to avoid opening the PR completely. I expect that who-ever does such a minor or major, will anyway have to bump it everywhere as part of shipping their project.
Also, atm concurrent PRs can break others & count against the SDK test users' ratelimiting, so this keeps the SDK test runners free for a bit longer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, as long as you're okay with creating more PRs by hand

Copy link
Member Author

@thgreasi thgreasi Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I have always done :) especially for our own packages

}
]
}
Loading