Update renovate config #1495
Update renovate config #1495
Conversation
Change-type: patch
.github/renovate.json
Outdated
| "packageRules": [ | ||
| { | ||
| "matchUpdateTypes": ["major", "minor", "patch", "digest"], | ||
| "groupName": "only-manually-bumped-packages", |
There was a problem hiding this comment.
You don't need a groupName if enabled == false.
.github/renovate.json
Outdated
| "matchUpdateTypes": [ | ||
| "major", | ||
| "minor" | ||
| ], | ||
| "automerge": false, |
There was a problem hiding this comment.
You don't need an automerge setting if enabled == false.
| "automerge": false, | ||
| "labels": ["renovate", "dependencies", "{{depType}}", "major"] | ||
| "enabled": false |
There was a problem hiding this comment.
Do you really want renovate to never open a PR for this, or would you like it to open a PR for convenience but never rebase it and disable automerge?
There was a problem hiding this comment.
If it's a major or a minor, which has a dependency of the proxy being bumped & deployed first, I think it makes sense to avoid opening the PR completely. I expect that who-ever does such a minor or major, will anyway have to bump it everywhere as part of shipping their project.
Also, atm concurrent PRs can break others & count against the SDK test users' ratelimiting, so this keeps the SDK test runners free for a bit longer.
There was a problem hiding this comment.
ack, as long as you're okay with creating more PRs by hand
There was a problem hiding this comment.
Like I have always done :) especially for our own packages
thgreasi
force-pushed
the
update-renovate
branch
from
475f1f8
to
d9711c1
Compare
.github/renovate.json
Outdated
| @@ -1,11 +1,16 @@ | |||
| { | |||
| "extends": ["github>balena-io/renovate-config"], | |||
| "prConcurrentLimit": 1, | |||
| "prConcurrentLimit": 3, | |||
There was a problem hiding this comment.
Why are you increasing this?
There was a problem hiding this comment.
B/c I expect that prHourlyLimit: 1 might help enough and having just 1 starving PR sounds like renovate will always be blocked. I can start w/ leaving prConcurrentLimit: 1 as it was and only increase it later if you prefer.
Yea let me do that...
Change-type: patch
Change-type: patch
Change-type: patch
thgreasi
force-pushed
the
update-renovate
branch
from
d9711c1
to
545bf72
Compare
flowzone-app
bot
closed this pull request by merging all changes
into
master
in
a5ff553
Resolves: #
HQ:
See:
Depends-on:
Change-type: major|minor|patch
Contributor checklist